Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[login] TRIM inputs before inserting into users or examiners #5810

Closed

Conversation

maltheism
Copy link
Member

Brief summary of changes

Issue:

user_accounts and examiner modules trim inputs before submission. request account does not do any trimming so entries like first/last name and emails get submitted with empty spaces around them.

This is particularly problematic for examiners where an examiner created with the incorrect Real_name value will cause a duplication of the examiner the first time the form is saved on user accounts because the name then gets trimmed and restored in it's correct format in the examiner table

result -> 500 error due to pselectrow returning more than one row

I added the trim method before the data is stored.

Links to related tickets (GitHub, Redmine, ...)

@maltheism maltheism added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Nov 28, 2019
@ridz1208
Copy link
Collaborator

I already submitted a pr

@maltheism maltheism closed this Nov 29, 2019
@maltheism maltheism deleted the 21.0-release_fix_requestaccount branch May 24, 2020 02:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants