[media] File download should retrieve decoded path #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesscall
added
Bug
|
21 isn't supported anymore and this doesn't look like an issue that would prevent updating, can you send this to 22 or 23? |
|
@driusan what if it's needed for 21 ? |
johnsaigle
added
Discussion Required
|
@johnsaigle I can put it in 22. can you just review it please ? |
johnsaigle
approved these changes
Jun 1, 2020
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 2, 2020
This aims to fix a bug that was experienced by a CCNA user when trying to download a file that had a '&' in the name. SQL encodes strings containing special chars and thus we need to use the decoded file names in the path when downloading files from media module.
Resolves aces#6136
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 2, 2020
This aims to fix a bug that was experienced by a CCNA user when trying to download a file that had a '&' in the name. SQL encodes strings containing special chars and thus we need to use the decoded file names in the path when downloading files from media module.
Resolves aces#6136
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 11, 2020
This aims to fix a bug that was experienced by a CCNA user when trying to download a file that had a '&' in the name. SQL encodes strings containing special chars and thus we need to use the decoded file names in the path when downloading files from media module.
Resolves aces#6136
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR is related to issue #6136. This PR aims to fix a bug that was experienced by a CCNA user when trying to download a file that had a '&' in the name. SQL encodes strings containing special chars and thus we need to use the decoded file names in the path when downloading files from media module.
Issuing this fix to the 21.0-release branch as it is affecting our users and current instance on CCNA.
Testing instructions (if applicable)
Link(s) to related issue(s)