Fix data in fields where HTML characters were double escaped on 22 #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
Add to Release Notes
|
@driusan as agreed, I have added the bugfix and the reporter script |
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 2, 2020
…ces#6477) This PR fixes the issue where special characters entered in instrument forms were double escaped on saving but improperly decoded on instrument loading causing each save to prepend an & escaping string to the already escaped characters. the problematic chars are &, <, > and ". The escaping is done in the deleted lines as well as the insert and update functions of the database class making this first instance unnecessary. A script has also been added to help projects identify if the bug has affected their data. Amending the data in the database will remain the responsibility of each project since it is highly specific to each project.
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 2, 2020
…ces#6477) This PR fixes the issue where special characters entered in instrument forms were double escaped on saving but improperly decoded on instrument loading causing each save to prepend an & escaping string to the already escaped characters. the problematic chars are &, <, > and ". The escaping is done in the deleted lines as well as the insert and update functions of the database class making this first instance unnecessary. A script has also been added to help projects identify if the bug has affected their data. Amending the data in the database will remain the responsibility of each project since it is highly specific to each project.
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 11, 2020
…ces#6477) This PR fixes the issue where special characters entered in instrument forms were double escaped on saving but improperly decoded on instrument loading causing each save to prepend an & escaping string to the already escaped characters. the problematic chars are &, <, > and ". The escaping is done in the deleted lines as well as the insert and update functions of the database class making this first instance unnecessary. A script has also been added to help projects identify if the bug has affected their data. Amending the data in the database will remain the responsibility of each project since it is highly specific to each project.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes the issue where special characters entered in instrument forms were double escaped on saving but improperly decoded on instrument loading causing each save to prepend an
&escaping string to the already escaped characters. the problematic chars are&,<,>and".The escaping is done in the deleted lines as well as the insert and update functions of the database class making this first instance unnecessary.
A script has also been added to help projects identify if the bug has affected their data. Amending the data in the database will remain the responsibility of each project since it is highly specific to each project.