Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[User accounts] New user email with pwd generation fix #6803

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[User accounts] New user email with pwd generation fix #6803

merged 1 commit into from
Jul 6, 2020

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jun 30, 2020 •
edited
Loading

When adding a new LORIS user, page returns error "Your password cannot be your email" when both "Make user name match email address" and "Generate new password" are checked.

This PR adds another condition to check if NA_UserID is set, which fixes the issue.

@laemtl laemtl added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jun 30, 2020
@laemtl laemtl mentioned this pull request Jun 30, 2020
Closed
@laemtl laemtl force-pushed the 2020-06-30-new-user-pwd-fix branch 2 times, most recently from d4de329 to 756255f Compare June 30, 2020 22:03
@ridz1208
Copy link
Collaborator

ridz1208 commented Jul 1, 2020

@laemtl i think this should be going to the 23 branch

@ridz1208 ridz1208 added the Critical to release PR or issue is key for the release to which it has been assigned label Jul 1, 2020
@ridz1208 ridz1208 added this to the 23.0.2 milestone Jul 1, 2020
@h-karim h-karim added the Passed Manual Tests PR has undergone proper testing by at least one peer label Jul 2, 2020
@laemtl laemtl force-pushed the 2020-06-30-new-user-pwd-fix branch from 756255f to 7432411 Compare July 2, 2020 13:20
@laemtl laemtl changed the base branch from master to 23.0-release July 2, 2020 13:21
@laemtl
Copy link
Contributor Author

laemtl commented Jul 2, 2020 •
edited
Loading

@ridz1208 Rebase done!

@ridz1208
Copy link
Collaborator

ridz1208 commented Jul 2, 2020

@laemtl travis needs a nudge

@laemtl
Copy link
Contributor Author

laemtl commented Jul 2, 2020

@ridz1208 Seemed related to a Travis issue... Validation is passing locally.

@laemtl
Copy link
Contributor Author

laemtl commented Jul 2, 2020 •
edited
Loading

Travis is not able to run the static suite:

npm run tests:$TEST_SUITE
npm ERR! missing script: tests:static
npm ERR! 
npm ERR! Did you mean this?
npm ERR!     tests:unit
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2020-07-02T15_54_49_689Z-debug.log
The command "npm run tests:$TEST_SUITE" exited with 1.
cache.2
store build cache

This is only happening on branch 23. I think the changes done to Travis in #5635 need to be merged in that branch too.

@ridz1208
Copy link
Collaborator

ridz1208 commented Jul 2, 2020

@kongtiaowang can you look into this ?

@kongtiaowang kongtiaowang reopened this Jul 2, 2020
@driusan driusan merged commit bf98a38 into aces:23.0-release Jul 6, 2020
spell00 pushed a commit to spell00/Loris that referenced this pull request Aug 13, 2020
@laemtl @spell00
[User accounts] New user email with pwd generation fix (aces#6803)
9b8a05b 
When adding a new LORIS user, page returns error "Your password cannot be your email" when both "Make user name match email address" and "Generate new password" are checked.

This adds another condition to check if NA_UserID is set, which fixes the issue.

    Resolves aces#6802
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 15, 2021
@laemtl @AlexandraLivadas
[User accounts] New user email with pwd generation fix (aces#6803)
dccace2 
When adding a new LORIS user, page returns error "Your password cannot be your email" when both "Make user name match email address" and "Generate new password" are checked.

This adds another condition to check if NA_UserID is set, which fixes the issue.

    Resolves aces#6802
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ridz1208 ridz1208 ridz1208 approved these changes

@h-karim h-karim h-karim approved these changes

Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
23.0.2
Development

Successfully merging this pull request may close these issues.

Error creating LORIS user when generating a password
5 participants
@laemtl @ridz1208 @h-karim @driusan @kongtiaowang