[Statistics/Behavioural] Detailed View and Double Data Entry - Site permission fix #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds per projects permissions restriction in the Detailed View
laemtl
requested changes
Jul 30, 2020
There was a problem hiding this comment.
It's working well for Data Entry Statistics, but the breakdown per participant for Double Data Entry Statistics displays entries for sites my user doesn't have access to (user can only access Pumpernickel/Montreal and can see Pumpernickel/Ottawa). If the user clicks on the link, it can also access the profile (whereas this profile is not accessible with the Access profile Search tool), which I think is another permission issue on the Candidate module level.
…ular center and/or project.
|
Hi @laemtl , thanks for catching this. Could you please check if the new commit fix the stats? Thank you. |
laemtl
added
the
Passed Manual Tests
|
@racostas Awesome, that fixes it, thank you! |
laemtl
approved these changes
Aug 3, 2020
|
@laemtl can you create a ticket describing how to reproduce the candidate accessing with URL hacking (ie. which module) so that it can be fixed? |
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
…ermission fix (aces#6861) Code refactorization of the functions _hasAccess and _checkCriteria. Adds per projects permissions restrictions. A user with permission data_entry should be now able to access the 'breakdown per participant' only for the sites and projects it have access to. Resolves aces#6659
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
…ermission fix (aces#6861) Code refactorization of the functions _hasAccess and _checkCriteria. Adds per projects permissions restrictions. A user with permission data_entry should be now able to access the 'breakdown per participant' only for the sites and projects it have access to. Resolves aces#6659
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
…ermission fix (aces#6861) Code refactorization of the functions _hasAccess and _checkCriteria. Adds per projects permissions restrictions. A user with permission data_entry should be now able to access the 'breakdown per participant' only for the sites and projects it have access to. Resolves aces#6659
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
…ermission fix (aces#6861) Code refactorization of the functions _hasAccess and _checkCriteria. Adds per projects permissions restrictions. A user with permission data_entry should be now able to access the 'breakdown per participant' only for the sites and projects it have access to. Resolves aces#6659
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Sep 2, 2021
…ermission fix (aces#6861) Code refactorization of the functions _hasAccess and _checkCriteria. Adds per projects permissions restrictions. A user with permission data_entry should be now able to access the 'breakdown per participant' only for the sites and projects it have access to. Resolves aces#6659
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Code refactorization of the functions
_hasAccessand_checkCriteria.Adds per projects permissions restrictions.
Testing instructions (if applicable)
A user with permission
data_entryshould be now able to access the 'breakdown per participant' only for the sites and projects it have access to.Link(s) to related issue(s)