Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Imaging_browser] Access to view session based on session project #6888

Merged
merged 2 commits into from
Aug 10, 2020
Merged

[Imaging_browser] Access to view session based on session project #6888

merged 2 commits into from
Aug 10, 2020

Conversation

ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented Aug 6, 2020

Brief summary of changes

Changed check from project from the candidate's registration project to the session's project.

solves #6872

@ridz1208 ridz1208 added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Aug 6, 2020
@driusan
Copy link
Collaborator

driusan commented Aug 6, 2020

This doesn't fully solve the ticket (the test plan/README isn't updated)

@ridz1208
Copy link
Collaborator Author

ridz1208 commented Aug 6, 2020

@driusan made the changes to testplan

cmadjar
cmadjar approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmadjar cmadjar added the Passed Manual Tests PR has undergone proper testing by at least one peer label Aug 6, 2020
@driusan driusan merged commit 0859b9b into aces:23.0-release Aug 10, 2020
@ridz1208 ridz1208 added this to the 23.0.2 milestone Aug 11, 2020
spell00 pushed a commit to spell00/Loris that referenced this pull request Aug 13, 2020
@ridz1208 @spell00
[Imaging_browser] Access to view session based on session project (ac…
0ba671c 
…es#6888)

Changed check from project from the candidate's registration project to the session's project on the view session page.

Resolves aces#6872
spell00 pushed a commit to spell00/Loris that referenced this pull request Aug 13, 2020
@ridz1208 @spell00
[Imaging_browser] Access to view session based on session project (ac…
5e7a284 
…es#6888)

Changed check from project from the candidate's registration project to the session's project on the view session page.

Resolves aces#6872
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 15, 2021
@ridz1208 @AlexandraLivadas
[Imaging_browser] Access to view session based on session project (ac…
edc0671 
…es#6888)

Changed check from project from the candidate's registration project to the session's project on the view session page.

Resolves aces#6872
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmadjar cmadjar cmadjar approved these changes

Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
23.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ridz1208 @driusan @cmadjar