Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NDB_BVL_Instrument] Only update instrument table if $values not empty #7124

Merged

Conversation

zaliqarosli
Copy link
Contributor

Brief summary of changes

This PR fixes the _save() method to call db update only if $values is not empty. This case pops up when you have a subtest with only static score elements. No error should be thrown so that $this->score() can eventually be called within the save() method.

Testing instructions (if applicable)

  1. Mock an instrument subtest with only static score fields or test with one that you already have
  2. on aces/main, click 'Save Data' on the front-end on that subtest. You will get a SQL error page.
  3. on this PR branch, repeat the above, and no errors. you can add a .score file to test that the scoring still works even if no values are saved

@zaliqarosli zaliqarosli reopened this Dec 10, 2020
@driusan driusan merged commit 137b536 into aces:main Jan 18, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
…ty (aces#7124)

This fixes the _save() method to call db update only if $values is not empty. This case pops up when you have a subtest with only static score elements. No error should be thrown so that $this->score() can eventually be called within the save() method.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants