[Battery] Potential improvement for battery assignment

[ridz1208]

Brief summary of changes

The behaviour change in the battery was copied over from the assign_missing _instruments php script. This is not the ideal implementation but is sufficient to serve as a proposal up for discussion. Alternate solutions can include

• completely separate function to populate vs create a battery
• only allow to "fill in" battery if already existing instruments are surveys (not a prepopulated battery of instruments)
• behaviour could be added uniquely to next stage (although this limits the potential to allow users to have a button au run "assign missing instruments from the front end")
• ... other combinations...

fixes #7162

[ridz1208]

@sruthymathew123 this is based on 21 so it should work as is, give it a try ?

[sruthymathew123]

@ridz1208 Tested on IBIS and works well.
I really appreciate your time to look on this.

[ridz1208]

@CamilleBeau you reported this in #7162 can you confirm this fix works for you ?

[CamilleBeau]

@CamilleBeau you reported this in #7162 can you confirm this fix works for you ?

Just tested this on the 23 upgrade branch on CCNA. No longer getting the 500 error, but now the rest of the instruments other than the added surveys are not populating in the battery. Is that intended?

[ridz1208]

@CamilleBeau def not

[CamilleBeau]

Looks good!