Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Publication] File delete not working (#6195 regression) #7284

Merged
merged 1 commit into from
Jan 18, 2021
Merged

[Publication] File delete not working (#6195 regression) #7284

merged 1 commit into from
Jan 18, 2021

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jan 9, 2021

To complement #7091, an additional error introduced by #6195 is fixed by this PR, when a file previously uploaded is deleted.

To test

  • Create a publication with a file and the necessary permission to edit (LORIS Users with Edit Permission).
  • Edit and delete the file.
  • The file should be deleted without error

@laemtl laemtl added Blocking PR should be prioritized because it is blocking the progress of another task Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) labels Jan 9, 2021
@laemtl laemtl mentioned this pull request Jan 9, 2021
Merged
kongtiaowang
kongtiaowang approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kongtiaowang kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label Jan 15, 2021
@driusan driusan merged commit d3203f7 into aces:main Jan 18, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
[Publication] File delete not working (aces#6195 regression) (aces#7284)
dc6982f 
Fix an error introduced by aces#6195 when a file previously uploaded is deleted.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees
No one assigned
Labels
Blocking PR should be prioritized because it is blocking the progress of another task Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@laemtl @kongtiaowang @driusan @ridz1208