-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[publication] Add columns to publications #7361
[publication] Add columns to publications #7361
Conversation
rebase after #7369 |
Thanks. |
The schema SQL file and RB_file need to be modified as well. Loris/SQL/0000-00-00-schema.sql Line 2148 in 1abab54
|
f7f23cd
to
649300f
Compare
I rebased and added the changes to the schema. Not sure what I should do about the RB_Files |
This should be going to the main branch |
e327977
to
5913c9f
Compare
Please ignore the RB files. It doesn't change the schema. |
@pierre-p-s try: "make clean" then "make dev", it may solve your issue. Good luck. |
It did not work for me |
@pierre-p-s what versions of node and npm do you have ?
|
node -v : v12.16.2 npm -v : 6.14.4 Do I need to update them? |
I don't think so I have the same versions and it works for me |
have you tried deleting |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We found a bug related to this. Fixing it now |
@pierre-p-s is this still needs work or can @kongtiaowang re-review it? |
@driusan Sorry forgot to delete the needs work tag. Yes it s ready for review |
After the 4th commit, the publication module can't save a publication into the database. |
@@ -66,9 +70,8 @@ function uploadPublication() : void | |||
$leadInvID = $db->pselectOne( | |||
'SELECT PublicationCollaboratorID '. | |||
'FROM publication_collaborator '. | |||
'WHERE Name = :n OR Email = :e', | |||
'WHERE Email = :e', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a different pull request if it's a different feature/bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted, will send a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments and added a new field: Project. |
@driusan this can be merged if you take a quick look at it |
Brief summary of changes
- Project,
- Date published,
- Journal,
- link and
- publishing status (dropdown menu with: in progress or published)
Testing instructions (if applicable)
Link(s) to related issue(s)