Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Behavioural QC] Add subproject filter #7430

Merged
merged 6 commits into from
Apr 26, 2021
Merged

[Behavioural QC] Add subproject filter #7430

merged 6 commits into from
Apr 26, 2021

Conversation

CamilleBeau
Copy link
Contributor

Brief summary of changes

This PR adds a subproject drop-down in the filters for Behavioural QC. This change was made on CCNA but should be relevant / useful to other projects as well.

Testing instructions (if applicable)

  1. Make sure that module loads properly
  2. Make sure that all drop downs in the filters are populated with the correct options
  3. Test the filters and make sure that the results are updated accordingly
  4. Make sure you can clear the filters, and the results are reset

HenriRabalais
HenriRabalais approved these changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@HenriRabalais HenriRabalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo but other than that LGTM!

modules/behavioural_qc/php/views/conflicts.class.inc Outdated Show resolved Hide resolved
HenriRabalais
HenriRabalais suggested changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@HenriRabalais HenriRabalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to hit request changes!

@driusan driusan merged commit 01fdfa1 into aces:main Apr 26, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@CamilleBeau @AlexandraLivadas
[Behavioural QC] Add subproject filter (aces#7430)
680f9f7 
A adds a subproject drop-down in the filters for Behavioural QC.
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@HenriRabalais HenriRabalais HenriRabalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CamilleBeau @HenriRabalais @driusan @ridz1208