-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Utility] Refactor getVisitInstruments function #7514
Merged
driusan
merged 7 commits into
aces:main
from
jesscall:2021_07_28_fix_utility_getVisitInstruments
Jun 6, 2022
Merged
[Utility] Refactor getVisitInstruments function #7514
driusan
merged 7 commits into
aces:main
from
jesscall:2021_07_28_fix_utility_getVisitInstruments
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesscall
added
Cleanup
PR or issue introducing/requiring at least one clean-up operation
php
Pull requests that update Php code
labels
Jul 28, 2021
jesscall
commented
Jul 28, 2021
*/ | ||
static function getVisitInstruments(string $visit_label): array | ||
{ | ||
$factory = \NDB_Factory::singleton(); | ||
$DB = $factory->database(); | ||
|
||
if ($DB->ColumnExists('test_battery', 'Test_name_display')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test_name_display
is not in the test_battery
table or schema
1 task
@kongtiaowang can you help with the unit testing? |
ridz1208
reviewed
Oct 25, 2021
ridz1208
reviewed
Oct 25, 2021
ridz1208
approved these changes
Mar 9, 2022
@jesscall can you rebase this to trigger the tests to run? I'm not sure why they're all stuck at "Expected" |
Co-authored-by: Rida Abou-Haidar <ridz1208@users.noreply.github.com>
Co-authored-by: Rida Abou-Haidar <ridz1208@users.noreply.github.com>
jesscall
force-pushed
the
2021_07_28_fix_utility_getVisitInstruments
branch
from
June 6, 2022 15:22
163c92e
to
74fce5c
Compare
@driusan rebased! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Comment in Utility Class
I should mention that the files mentioned in the comment no longer exist and as far as I can tell there are no other uses of this function in the code base.
Testing instructions (if applicable)
[$Test_name => $Full_name]