[Ci] Fix Build on v23 branch #7580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a test to trigger a run of GitHub Actions.
driusan
changed the title
driusan
added
Blocking
driusan
commented
Sep 24, 2021
| @@ -1545,7 +1545,6 @@ class CheckboxElement extends React.Component { | |||
| let errorMessage = null; | |||
| let requiredHTML = null; | |||
| let elementClass = this.props.elementClass; | |||
| let label = null; | |||
There was a problem hiding this comment.
This is never used and causing an error in eslint, which causes npm run compile to fail.
|
@kongtiaowang can you review this? The build is currently broken for v23 |
|
@driusan LGTM |
kongtiaowang
approved these changes
Sep 24, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7579 is failing on
npm run compileeven though it doesn't touch javascript.This PR fixes the build on the
23.0-releasebranch.