Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[NDB_BVL_Instrument] JSON Data support fix DECS field #7819

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[NDB_BVL_Instrument] JSON Data support fix DECS field #7819

merged 1 commit into from
Nov 17, 2021

Conversation

ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented Nov 10, 2021 •
edited
Loading

Brief summary of changes

When Data column is empty (before first save) this returns NULL which causes an issue since this method expects a string returned

@ridz1208 ridz1208 added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Nov 10, 2021
@ridz1208 ridz1208 mentioned this pull request Nov 10, 2021
Merged
@ridz1208
Copy link
Collaborator Author

@driusan this is a fix going to 23

@ridz1208 ridz1208 added the Critical to release PR or issue is key for the release to which it has been assigned label Nov 16, 2021
@driusan driusan mentioned this pull request Nov 16, 2021
Closed
@CamilleBeau CamilleBeau added the Passed Manual Tests PR has undergone proper testing by at least one peer label Nov 17, 2021
@ridz1208 ridz1208 merged commit 31fc22f into aces:23.0-release Nov 17, 2021
@ridz1208 ridz1208 added this to the 23.0.9 milestone Nov 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CamilleBeau CamilleBeau CamilleBeau approved these changes

@driusan driusan driusan approved these changes

Assignees

@CamilleBeau CamilleBeau

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
23.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@ridz1208 @driusan @CamilleBeau