-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[api] Modify YAML schema so that Swagger Codegen PHP Client works #7857
Conversation
@zaliqarosli Fixes should changes schema.yml but other changes needs to go in schema-v0.0.4-dev.yml (e.g.: |
@zaliqarosli after speaking to @driusan the only remaining issues on this PR is that the instrument.class.inc endpoint is being modified which impacts all API versions. @xlecours could you instruct @zaliqarosli how to deal with that? I think we were creating a copy of the class and tagging it with the api version... is that it? like |
|
ab9a4bf
to
7648555
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaliqarosli While I was trying the schema-v0.0.4-dev.yml file in swagger editor, it complained about multiple entries in the components that are defined twice. Would you mind fixing these in this PR as well?
ex: VisitStage, InstrumentVisit, ...
I'll approve the PR in its current stage anyways.
Thanks
@xlecours i am getting these failed tests
which I don't understand as the instrument endpoint is clearly returning 204 No Content, and I'm not sure where the 200 is coming from. do you have any ideas? |
add other sex option add Meta property to visitmeta redo remove dynamic key instrumentData is empty class if no properties set change other instances of $instrumentname move to v0.0.04 add Other sex to docs phan add switch for versions cleanup + add more version checks fixes add to v4 fix return with 204 add missing ; remove duplicated fix schema fix test for v0.0.0-4
fb8c396
to
ef06d09
Compare
@ridz1208 Do you mean 24.1 or the next release? |
I agree with @xlecours but isnt that the reason the API is versioned separately than LORIS? as long as its going to 0.0.4-dev it should be fine if it goes in 24.1 as far as I understand |
@ridz1208 yes but this PR is changing 0.0.3 |
nm, just saw that it's only the "other" part going to 0.0.3. |
Brief summary of changes
This PR:
Fixes:
Changes:
Testing instructions (if applicable)
Link(s) to related issue(s)