-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[DQT] add delete feature #8078
[DQT] add delete feature #8078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kongtiaowang the feature works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kongtiaowang I reviewed again and the only thing I see left is the eslint-disable-line(s) that should probably be removed? Also this new delete feature should probably be added to the changelog file of Loris.
eslint fix
@maltheism Thanks |
Hi @maltheism Could you test it again? Thanks |
HI @kongtiaowang I can still delete successfully. Passed manual tests! |
Thanks @xlecours @maltheism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Brief summary of changes
Add delete feature for DQT
Add tools/dqt_delete_saved_query.php
Testing instructions (if applicable)