[DQT] v23 - Fix dictionary builder and dictionary display issues #8116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
changed the title
driusan
reviewed
Jul 5, 2022
| @@ -185,7 +195,7 @@ | |||
| "Type" => $bits[0], | |||
| "Description" => $bits[2], | |||
| "SourceField" => $bits[1], | |||
| "SourceFrom" => $table, | |||
| "SourceFrom" => $testname, | |||
There was a problem hiding this comment.
I don't think this part is accurate. SourceFrom is supposed to be the table in the quat tables that the data is sourced from.. but I also don't think it matters, because the quat tables don't exist/aren't used anymore and as far as I know this isn't used anywhere, so I'll just merge it..
cmadjar
pushed a commit
to cmadjar/Loris
that referenced
this pull request
Aug 10, 2022
- backporting fix for the display of the dictionary in the DQT module aces#7098 - in the data_dictionary_builder script, reference the tesname value in parsed instruments (lorisform parser output format) instead of table while keeping it backwards compatible. This is needed because JSONdata instruments do not define a table variable and since [23.0.3] (https://github.com/aces/Loris/pull/7153/files#diff-962394c093e5275dcfa7cc6eca8927b2f8f592f42b7b95ec5921cb7fc0dc8453R88) the lorisform parser exports the test name in its output for this specific reason.
cmadjar
pushed a commit
to cmadjar/Loris
that referenced
this pull request
Sep 20, 2022
- backporting fix for the display of the dictionary in the DQT module aces#7098 - in the data_dictionary_builder script, reference the tesname value in parsed instruments (lorisform parser output format) instead of table while keeping it backwards compatible. This is needed because JSONdata instruments do not define a table variable and since [23.0.3] (https://github.com/aces/Loris/pull/7153/files#diff-962394c093e5275dcfa7cc6eca8927b2f8f592f42b7b95ec5921cb7fc0dc8453R88) the lorisform parser exports the test name in its output for this specific reason.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR is 2 parts:
tesnamevalue in parsed instruments (lorisform parser output format) instead oftablewhile keeping it backwards compatible. This is needed because JSONdata instruments do not define atablevariable and since [23.0.3] (https://github.com/aces/Loris/pull/7153/files#diff-962394c093e5275dcfa7cc6eca8927b2f8f592f42b7b95ec5921cb7fc0dc8453R88) the lorisform parser exports the test name in its output for this specific reason.