[user_accounts] Prevent crash when one user has no site/project affiliations #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
the
Critical to release
|
I cherry-picked this onto 24 so I can test it and (after resolving conflicts in UserAccountRowProvisioner), this works for sites. When a user has no project affiliation, the user gets filtered out of the user accounts table because they have no projects in common with the logged in user. Is this the expected behaviour? |
|
@driusan i was not expecting it but it seems to be what happens. I'm not as concerned about it. its better than a crash |
|
I'm not sure if it's what we want.. I think the users will become orphans with no one able to find them but as you say, it's better than a crash, so I'm approving.. |
driusan
approved these changes
Jul 14, 2022
cmadjar
pushed a commit
to cmadjar/Loris
that referenced
this pull request
Aug 10, 2022
…ations (aces#8139) Although this use case should never happen as it is prevented by rules in the edit_user logic, a couple bugs have let it happen in the past and the entire module becomes inaccessible. This makes the module load and displays a message in the user row informing the editor that the user does not currently have any sites and projects. The only way to test this would be to manually delete all site associations directly in the DB user_psc_rel OR all project associations user_project_rel Note that the module crashes even if the user not having any sites or projects is not the editor nor the editee... any user can cause this issue.
cmadjar
pushed a commit
to cmadjar/Loris
that referenced
this pull request
Sep 20, 2022
…ations (aces#8139) Although this use case should never happen as it is prevented by rules in the edit_user logic, a couple bugs have let it happen in the past and the entire module becomes inaccessible. This makes the module load and displays a message in the user row informing the editor that the user does not currently have any sites and projects. The only way to test this would be to manually delete all site associations directly in the DB user_psc_rel OR all project associations user_project_rel Note that the module crashes even if the user not having any sites or projects is not the editor nor the editee... any user can cause this issue.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Although this usecase should never happen as it is prevented by rules in the edit_user logic, a couple bugs have let it happen in the pass and the entire module becomes inaccessible. This makes the module load and displays a message in the user row informing the editor that the user does not currently have any sites and projects.
The only way to test this would be to manually delete all site associations directly in the DB
user_psc_relOR all project associationsuser_project_relNote that the module crashes even if the user not having any sites or projects is not the editor nor the editee... any user can cause this issue