Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add phase encoding direction and echo number to mri protocol and mri protocol violated scans #8150

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Aug 10, 2022

Brief summary of changes

This adds the columns PhaseEncodingDirections and EchoNumber to the mri_protocol and mri_protocol_violated_scans tables so that those headers could be used to discriminate between some MRI sequences.

Testing instructions (if applicable)

  1. Test the SQL patch
  2. Test the default schema on an empty DB

Link(s) to related issue(s)

  • Did not create an issue. This was discussed during a roadmap call.

Related to PR on LORIS-MRI side: aces/Loris-MRI#782

@cmadjar cmadjar added the SQL PR contains SQL modifications such as schema changes and new SQL scripts label Aug 10, 2022
@cmadjar
Copy link
Collaborator Author

cmadjar commented Aug 10, 2022

@driusan eventually, we will need to modify the mri_violations module to display those new fields. I see that image_type is not in the mri_violations either so I was thinking of sending a different PR to fix this so that at least the MRI side of things work for the insertion.

Thoughts? If you agree, then I will create an issue and assign to me. Thanks!

@cmadjar cmadjar changed the base branch from main to 24.1-release August 10, 2022 13:55
@cmadjar cmadjar added the Blocking PR should be prioritized because it is blocking the progress of another task label Aug 10, 2022
@cmadjar cmadjar changed the title Add phase encoding direction and scan options to mri protocol and mri protocol violated scans 24.1 release Add phase encoding direction and echo number to mri protocol and mri protocol violated scans 24.1 release Aug 10, 2022
@cmadjar cmadjar changed the title Add phase encoding direction and echo number to mri protocol and mri protocol violated scans 24.1 release Add phase encoding direction and echo number to mri protocol and mri protocol violated scans Aug 10, 2022
…ptions_to_mri_protocol_and_mri_protocol_violated_scans_24.1-release
@driusan driusan merged commit 12b1443 into aces:24.1-release Aug 18, 2022
@ridz1208 ridz1208 added this to the 24.1.0 milestone Aug 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Blocking PR should be prioritized because it is blocking the progress of another task SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants