Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove dangling SNR from the image panel in the imaging browser when SNR is not available for the image #8155

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Remove dangling SNR from the image panel in the imaging browser when SNR is not available for the image #8155

merged 1 commit into from
Sep 27, 2022

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Aug 22, 2022

Brief summary of changes

This modifies the image panel of the imaging browser to get rid of the weird dangling SNR label when no SNR value is associated to the file.

image

Testing instructions (if applicable)

  1. On branch 24.0-release or latest bug fix release for 24.0, check that the SNR label is always there whether there is actually an SNR value to be displayed or not
  2. On this branch, check that the SNR label shows only for images that have SNR values associated to them

Link(s) to related issue(s)

@cmadjar cmadjar added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Aug 22, 2022
@cmadjar cmadjar force-pushed the 2022-08-22_bug_fix_remove_SNR_from_imaging_browser_when_not_available_for_image branch from 0b83c3f to f83e70c Compare September 22, 2022 17:33
@cmadjar cmadjar changed the base branch from 24.0-release to 24.1-release September 22, 2022 17:34
@CamilleBeau CamilleBeau added the Passed Manual Tests PR has undergone proper testing by at least one peer label Sep 27, 2022
@cmadjar cmadjar force-pushed the 2022-08-22_bug_fix_remove_SNR_from_imaging_browser_when_not_available_for_image branch from f83e70c to 90c17a6 Compare September 27, 2022 15:38
@driusan driusan merged commit c878c1e into aces:24.1-release Sep 27, 2022
@ridz1208 ridz1208 added this to the 24.1.0 milestone Nov 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CamilleBeau CamilleBeau CamilleBeau approved these changes

Assignees
No one assigned
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
24.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cmadjar @CamilleBeau @driusan @ridz1208