-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[imaging browser] add download buttons for BIDS JSON file (and NIfTI bval, bvec files for DWI) #8159
[imaging browser] add download buttons for BIDS JSON file (and NIfTI bval, bvec files for DWI) #8159
Conversation
can you send this to 24.1-release? |
33f621c
to
056ff74
Compare
@driusan rebase on 24.1-release done! |
b8d8ee5
to
230caac
Compare
I was able to successfully download BVEC, BVAL and JSON files with the new buttons. Approving. |
htdocs/mri/jiv/get_file.php
Outdated
break; | ||
case 'json': | ||
$FullPath = $imagePath . '/' . $File; | ||
$MimeType = 'apllication/json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed in the last commit
47a627b
to
10cc0fa
Compare
Brief summary of changes
Currently, the image download button says 'Download MINC' which is wrong when the file attached is a NIfTI file or another image file format. Instead, the "Download MINC" has been rephrased to a more generic option "Download Image".
For DWI NIfTI files, users should also be able to download the BVAL and BVEC files that come with NIfTI DWI files. This PR adds a download button for each of those files when they are linked to the image file in the
parameter_file
table.Similarly, for BIDS datasets, there are JSON files that comes with the image file that should be made available for download so this PR adds a download button to the imaging browser if a JSON file is linked to the NIfTI image file in the
parameter_file
table.Testing instructions
Load a BIDS dataset with DWI data and other modalities into LORIS and check that the relevant buttons show in the frontend.
files
table and add the following entries in theparameter_file
tableparameter_type
Name
check_bval_filename
parameter_type
Name
check_bvec_filename
parameter_type
Name
bids_json_file
The button should then be seen on the imaging browser. Make sure the paths are relative to the
imagePath
Config.Link(s) to related issue(s)