Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tools & instruments] Fix DB calls #8162

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

zaliqarosli
Copy link
Contributor

@zaliqarosli zaliqarosli commented Sep 1, 2022

Brief summary of changes

Similar PR to #8128, assign_missing_instruments and instruments themselves got missed in #8074

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. On main branch, try running tools/assign_missing_instruments.php and see error.
  2. On main branch, try to render and save instruments and see errors in error log
  3. On PR branch, repeat both steps without getting any errors

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@driusan
Copy link
Collaborator

driusan commented Sep 6, 2022

do these need to be fixed in the latest release or just on main?

@zaliqarosli
Copy link
Contributor Author

@driusan issue does exist on 24.1-release .. should i change branches?

@driusan
Copy link
Collaborator

driusan commented Sep 6, 2022

yes, please.

@zaliqarosli zaliqarosli changed the base branch from main to 24.1-release September 6, 2022 15:27
@zaliqarosli zaliqarosli closed this Sep 6, 2022
@zaliqarosli zaliqarosli reopened this Sep 6, 2022
@driusan driusan merged commit be23bf2 into aces:24.1-release Sep 12, 2022
@ridz1208 ridz1208 added this to the 24.1.0 milestone Sep 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants