-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Download NIfTI file from imaging browser when a NIfTI file is available in addition to a MINC file #8206
Download NIfTI file from imaging browser when a NIfTI file is available in addition to a MINC file #8206
Conversation
…TI file is available in addition to the MINC file
@nicolasbrossard could you please review/test this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I pulled the branch on my VM and tested this. Everything works great. Should there be any mention of this new feature in the doc/help?
@@ -826,6 +826,10 @@ class ImageDownloadButtons extends Component { | |||
BaseURL={this.props.BaseURL} | |||
Label="Download NRRD" | |||
/> | |||
<DownloadButton FileName={this.props.NiiFile} | |||
BaseURL={this.props.BaseURL} | |||
Label="Download NIfTI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know that NIfTI was spelt with a lowercase "f"...Noted!
@nicolasbrossard thank you for the review. The documentation is pretty limited but I modified the HELP text file |
@driusan ready for you! |
@@ -1,6 +1,6 @@ | |||
# Imaging Browser: View Session | |||
|
|||
This page displays a candidate's scans collected from a single timepoint. Click on any image to launch the BrainBrowser visualization tool. With every file displayed, there are different actions you can take, such as change the file's QC status, add or edit the QC comments, download the MINC file, or see a longitudinal view (in BrainBrowser). Click **Header Info** to see further scan parameters from the DICOM header. | |||
This page displays a candidate's scans collected from a single timepoint. Click on any image to launch the BrainBrowser visualization tool. With every file displayed, there are different actions you can take, such as change the file's QC status, add or edit the QC comments, download the imaging files (MINC/NIfTI), or see a longitudinal view (in BrainBrowser). Click **Header Info** to see further scan parameters from the DICOM header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the "with every file displayed" wording confusing but it was there before so it's beyond the scope of this PR..
…TI file is available in addition to a MINC file (aces#8206) This modifies the imaging browser so that NIfTI files associated to a MINC file can be downloaded through the imaging browser view session page. Currently, we can download BVAL and BVEC files when they are present for DWI but could not download the NIfTI file that comes with it. This is a bug fix for projects using MINC files and producing NIfTI files at the time of insertion so that they can download.
Brief summary of changes
This modifies the imaging browser so that NIfTI files associated to a MINC file can be downloaded through the imaging browser view session page. Currently, we can download BVAL and BVEC files when they are present for DWI but could not download the NIfTI file that comes with it.
This is a bug fix for projects using MINC files and producing NIfTI files at the time of insertion so that they can download.
Testing instructions (if applicable)
Download Image
=> will download a MINC file (extension.mnc
)Download BVAL
=> will download a .bval text fileDownload BVEC
=> will download a .bvec text fileDownload NIfTI
for raisinbread DWI MINC files with NIfTI files