Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[issue tracker] Email watchers when issue is updated or created #8248

Merged
merged 3 commits into from
Dec 2, 2022
Merged

[issue tracker] Email watchers when issue is updated or created #8248

merged 3 commits into from
Dec 2, 2022

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Dec 1, 2022

Brief summary of changes

When people are added to the watchers list, they do not receive a notification email upon creation/update of the issue. This fixes the bug and allows notification to be sent to watchers when an issue is created/updated.

Testing instruction

  • on branch 24.1-release, create an issue and add a user in the watchers list (the user should be different than the user creating the issue) and notice that no email is sent to that user [tested on 24.1 demo]
  • checkout this branch and check that users marked as watcher receive notification email when creating or updating the new issue

This resolves #8004

@cmadjar cmadjar added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS php Pull requests that update Php code 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Dec 1, 2022
@CamilleBeau CamilleBeau added the Passed Manual Tests PR has undergone proper testing by at least one peer label Dec 2, 2022
@CamilleBeau
Copy link
Contributor

Manual test went well!

@driusan driusan merged commit fadeec0 into aces:24.1-release Dec 2, 2022
@ridz1208 ridz1208 added this to the 24.1.2 milestone Feb 1, 2023
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this pull request Mar 6, 2023
@cmadjar @zaliqarosli
[issue tracker] Email watchers when issue is updated or created (aces…
902d900 
…#8248)

When people are added to the watchers list, they do not receive a notification email upon creation/update of the issue. This fixes the bug and allows notification to be sent to watchers when an issue is created/updated.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CamilleBeau CamilleBeau CamilleBeau approved these changes

Assignees
No one assigned
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer php Pull requests that update Php code Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Milestone
24.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@cmadjar @CamilleBeau @driusan @ridz1208