-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Jsdoc update #8266
Jsdoc update #8266
Conversation
93d0ac3
to
ed1d064
Compare
What does this do? |
what do you mean "enforced to follow the jsdoc rules"? |
@@ -2,11 +2,25 @@ | |||
"parser": "@babel/eslint-parser", | |||
"plugins": [ | |||
"react", | |||
"no-jquery" | |||
"no-jquery", | |||
"jsdoc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@driusan jsdoc has been added to the plugins. When "valid-jsdoc": "off"
is set to "error"
then we will get errors when running npm run compile
such as if comments are missing @return
or correct @param
value. Also the comments now have a standardized structure requirement similar to php. I believe @laemtl has the rule currently set to off because she's cleaning up the comments in parts by separate PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups I forgot to add a description. Thanks @maltheism for the clarifications!
No description provided.