-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Document Repository] Upload multiple files at once #8289
[Document Repository] Upload multiple files at once #8289
Conversation
tagging Santiago for review of the feature - i think the issue originated from his request? If it was another project/person requesting, feel free to pass this on |
resolves #8218 |
this PR needs review @miladheshmati @SantiagoTG @laemtl this is still on the roadmap for 25? |
@christinerogers, I checked the code, the code seems fine, however, due to some technical problems on my VM, I was not able to test it there. |
@christinerogers Yes it is still on the roadmap. |
@miladheshmati any more success testing it this week? |
There was challenges with my VM but thanks to @CamilleBeau, it is solved now and I was able to test it today |
Thanks for the review! The issue you are experiencing was not introduced by this PR and it is because the 'Site' element is not a <SelectElement> like the fields above and below, but a <SearchableDropdown> element. You will notice that you can also type in this field to narrow the options, and when you delete the text in the field, all options are available again. |
body: formObject, | ||
}) | ||
.then((resp) => { | ||
console.error(resp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is resp always unconditionally logged as an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why that was done but it was not introduced by this PR. It seems to be a forgotten debugging snippet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be moved in the logic where the resp returns an error (else case ligne 222)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Done.
- <FileElement> now supports the 'multiple' attribute. - The document_repository module has been modified to support multiple uploaded files. - Some visual feedback has been added (error reporting + uploading status). Resolves aces#8218
Brief summary of changes
Testing instructions
Related issue: #8218