Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Webpack] Compilation error fix #8293

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Dec 20, 2022

Address an issue that prevents webpack and the post-install script to run when patch SQL/New_patches/2022-12-05-AddVizConfig.sql is not applied.

Now the errors are caught and a warning is printed on the screen.

Screen Shot 2022-12-20 at 1 22 45 PM

@zaliqarosli zaliqarosli added the Passed Manual Tests PR has undergone proper testing by at least one peer label Dec 20, 2022
@laemtl laemtl added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Dec 20, 2022
@driusan
Copy link
Collaborator

driusan commented Dec 20, 2022

@laemtl was about to merge this then noticed the needs work tag.. what's needed on this?

@laemtl laemtl removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Dec 20, 2022
Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR in 
/var/www/loris/npm-postinstall.js
  114:10  error  Parsing error: The only valid numeric escape in strict mode is '\0'. (114:10)

✖ 1 problem (1 error, 0 warnings)

@laemtl
Copy link
Contributor Author

laemtl commented Dec 20, 2022

@laemtl was about to merge this then noticed the needs work tag.. what's needed on this?

The same fix was needed for npm-postinstall.js as well. It's done.

@laemtl
Copy link
Contributor Author

laemtl commented Dec 20, 2022

ERROR in 
/var/www/loris/npm-postinstall.js
  114:10  error  Parsing error: The only valid numeric escape in strict mode is '\0'. (114:10)

✖ 1 problem (1 error, 0 warnings)

Thanks and fixed!

@driusan driusan merged commit 4aaf5eb into aces:main Dec 20, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants