Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[jsx/Panel.js] Improved Panel component with optional multiple views #8299

Merged
merged 6 commits into from
Mar 21, 2023
Merged

[jsx/Panel.js] Improved Panel component with optional multiple views #8299

merged 6 commits into from
Mar 21, 2023

Conversation

maltheism
Copy link
Member

Brief summary of changes

Updated the Panel component to handle views if given. Also refactored the code to be a react functional component instead of a class. Used in PR: #8261

Testing instructions (if applicable)

  1. checkout pr
  2. make clean && make dev
  3. visit modules that use the Panel component and see if anything broke.

@maltheism maltheism added Feature PR or issue introducing/requiring at least one new feature Cleanup PR or issue introducing/requiring at least one clean-up operation javascript Pull requests that update Javascript code labels Dec 20, 2022
@maltheism maltheism mentioned this pull request Dec 20, 2022
Closed
@CamilleBeau
Copy link
Contributor

The arrows to collapse the panel are not rendering correctly:

image

Things are looking good other than this!

@CamilleBeau CamilleBeau added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Feb 27, 2023
@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
@laemtl laemtl removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Mar 16, 2023
@laemtl laemtl force-pushed the react_panel_multiple_views branch from e100df3 to 4a3fcce Compare March 16, 2023 16:10
@laemtl laemtl force-pushed the react_panel_multiple_views branch from 4a3fcce to ffad66a Compare March 16, 2023 16:50
@laemtl laemtl force-pushed the react_panel_multiple_views branch from ffad66a to 34e711a Compare March 16, 2023 16:53
@laemtl
Copy link
Contributor

laemtl commented Mar 16, 2023 •
edited
Loading

Ready. I also rebased the PR to get rid of the unrelevant commits.
-- Update: I need to fix an integration test.

@laemtl laemtl added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Mar 16, 2023
@laemtl laemtl removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Mar 16, 2023
@laemtl
Copy link
Contributor

laemtl commented Mar 16, 2023

Ready

@laemtl
Copy link
Contributor

laemtl commented Mar 20, 2023

@CamilleBeau Can you retest and approve if this fixes your issue?

@CamilleBeau
Copy link
Contributor

@CamilleBeau Can you retest and approve if this fixes your issue?

Approved! It's fixed now. Thanks Laetitia!

@driusan driusan merged commit 22fc463 into aces:main Mar 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CamilleBeau CamilleBeau CamilleBeau approved these changes

@driusan driusan Awaiting requested review from driusan

@laemtl laemtl Awaiting requested review from laemtl

Assignees

@CamilleBeau CamilleBeau

Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Feature PR or issue introducing/requiring at least one new feature javascript Pull requests that update Javascript code
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maltheism @CamilleBeau @laemtl @driusan