-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[instruments/instrument_manager] Migrate instrument permissions from config.xml to database #8302
Conversation
ef7ac69
to
96a1d1a
Compare
Blocked by #8290 |
Makefile
Outdated
instrument_manager: | ||
target=instrument_manager npm run compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a leftover or are we adding this for every module now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been adding it for modules when I work on them because it makes life easier but haven't systematically added every module.
ab717a8
to
b28ce82
Compare
Note: this will need to be rebased/re-tested after #8422 in case of conflicts with the instrument manager |
TODO: - Create table and patch - Write script to migrate - Create frontend for managing table
88b56c1
to
28bf6cf
Compare
This migrates instrument permissions from the config.xml to the database in a new
testnames_permissions_rel
table. The table can be managed from the frontend in theinstrument_manager
module by any user who has theinstrument_manager_write
permission. The scripttools/single_use/migrate_instrument_permissions.php
can be used by existing projects to migrate their permissions from the config.xml to the new table.