-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[issue_tracker] Display attachments #8346
[issue_tracker] Display attachments #8346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeighMac @CamilleBeau I have tested the new feature and it works perfectly.
@CamilleBeau can't merge because of a conflict in the changelog, can you rebase? |
Done! Sorry abou that. |
{regexImg.test(item.mime_type) ? | ||
(<img | ||
src={this.props.baseURL + | ||
'/issue_tracker/Attachment' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a very nice URL. It would be better if it was routed as something like https://example.com/issue_tracker/issue/1234/attachments/filename.pdf
but I'm not gonna block over it because the endpoint is already there.
Brief summary of changes
This PR was originally made by Pierre Pac-Soo on CCNA here. The changes allow image attachments to be displayed in the issue instead of having to download.
Testing instructions (if applicable)
Link(s) to related issue(s)