Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[issue tracker] Fix issue description #8351

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Feb 1, 2023

The issue description is currently rendered in a static text field, while comments (or the description in the comments) are rendered as markdown. This updates the description to be wrapped in a <Markdown> tag so that it gets consistently rendered.

The issue description is currently rendered in a static text field, while comments (or the description in the comments) are rendered as markdown. This updates the description to be wrapped in a `<Markdown>` tag so that it gets consistently rendered.
@driusan driusan added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Feb 1, 2023
@driusan driusan added this to the 24.1.1 milestone Feb 1, 2023
@driusan
Copy link
Collaborator Author

driusan commented Feb 1, 2023

@cmadjar this is for you

@ridz1208 is there a better milestone to tag? I think 24.1.1 was already released but it was the only option?

@ridz1208 ridz1208 modified the milestones: 24.1.1, 24.1.2 Feb 1, 2023
@cmadjar
Copy link
Collaborator

cmadjar commented Feb 2, 2023

milestone 24.1.2 makes sense to me. Thanks @ridz1208 for making it!

@cmadjar
Copy link
Collaborator

cmadjar commented Feb 13, 2023

@driusan I just tested your PR and it does not look like Markdown is being rendered in the description:
Screen Shot 2023-02-13 at 11 15 43 AM

(The URL works in the comments and history though)

@driusan
Copy link
Collaborator Author

driusan commented Feb 13, 2023

Are you sure you ran make and that it's not using a cached version of the old issue tracker js? Markdown links like you used are working for me (though bare URLs aren't automatically linked.)

Issue Tracker screenshot

Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks @driusan

PS: the overrides tricked me in believing it did not work. :(

@driusan driusan merged commit cc9997b into aces:24.1-release Feb 13, 2023
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this pull request Mar 6, 2023
The issue description is currently rendered in a static text field, while comments (or the description in the comments) are rendered as markdown. This updates the description to be wrapped in a `<Markdown>` tag so that it gets consistently rendered.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants