-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[document_repository] Fix download path to correct user #8378
[document_repository] Fix download path to correct user #8378
Conversation
@zaliqarosli @charliehenrib I'm confused how this is not a much much bigger issue. Shouldn't this prevent pretty much anyone from downloading any file that they didnt upload themselves ?? |
@CamilleBeau do you have a VM where you can pull this for charlie to test ? |
Yes I will pull this onto our dev VM |
@ridz1208 i think it depends on what projects have this bug cz it was fixed for a certain version, and then the code refactored that re-introduced it. i know that it was something I had to fix for COPN on 21.. but it had already been fixed for a later version |
@CamilleBeau @ridz1208 I followed the testing steps above and it works exactly as described. Is there a passed manual testing label that I should add? |
f6182f5
to
48bb685
Compare
@driusan i fixed it to what you suggested. can you re-review? |
Code looks good to me. @charliehenrib can you re-test it? |
I retested and it works as it should :) |
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)