Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[media] add feedback to dropdown field when is empty #8402

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

shonibare
Copy link
Contributor

Fixes #7951

@ridz1208 ridz1208 self-assigned this Mar 6, 2023
@ridz1208 ridz1208 changed the title add feedback to dropdown field when is empty [media] add feedback to dropdown field when is empty Mar 8, 2023
@ridz1208
Copy link
Collaborator

ridz1208 commented Mar 9, 2023

Screenshot from 2023-03-08 20-13-07

not exactly how I was expecting the placeholder to behave. it shows up as an actual option not a place holder. @driusan im on the fence about this but functionally it works.

@driusan
Copy link
Collaborator

driusan commented Mar 9, 2023

@ridz1208 how are you expecting a placeholder for a dropdown to work?

@ridz1208
Copy link
Collaborator

ridz1208 commented Mar 9, 2023

Screenshot_20230309_091505_com android chrome

Like a placeholder

Copy link
Collaborator

@ridz1208 ridz1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found (see screenshots)

To reproduce on RB:

  1. go to the upload form
  2. select candidate DCC090 + V2 + AOSI
  3. change candidate to DCC355
  4. ERROR

Screenshot from 2023-03-09 09-54-15

to reproduce without RB:
try choosing a candidate which has visits and a visit and an instrument then try selecting a candidate which doesn't have any visits

@shonibare
Copy link
Contributor Author

Issue found (see screenshots)

To reproduce on RB:

  1. go to the upload form
  2. select candidate DCC090 + V2 + AOSI
  3. change candidate to DCC355
  4. ERROR

Screenshot from 2023-03-09 09-54-15

to reproduce without RB: try choosing a candidate which has visits and a visit and an instrument then try selecting a candidate which doesn't have any visits

Error fixed

@ridz1208 ridz1208 added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 9, 2023
@driusan driusan merged commit 006f50a into aces:24.1-release Mar 13, 2023
@ridz1208 ridz1208 added this to the 24.1.3 milestone Mar 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants