-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Core] Remove Database::singleton function #8427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
the
"Help! I don't understand Travis!"
PR is having a beef with TRAVIS. Someone needs to help
label
Mar 7, 2023
ridz1208
reviewed
Mar 8, 2023
docs/instruments/NDB_BVL_Instrument_UPLOADER_TEMPLATE.class.inc
Outdated
Show resolved
Hide resolved
ridz1208
reviewed
Mar 8, 2023
ridz1208
previously approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good other than the couple comments
driusan
added
Cleanup
PR or issue introducing/requiring at least one clean-up operation
and removed
"Help! I don't understand Travis!"
PR is having a beef with TRAVIS. Someone needs to help
labels
Mar 8, 2023
@kongtiaowang it seems like some unit tests can't connect to the database but the log has the credentials and it's consistently the same tests.. do you have any ideas? |
driusan
added
the
"Help! I don't understand Travis!"
PR is having a beef with TRAVIS. Someone needs to help
label
Mar 8, 2023
driusan
removed
the
"Help! I don't understand Travis!"
PR is having a beef with TRAVIS. Someone needs to help
label
Mar 8, 2023
@ridz1208 getting the tests to pass took more significant changes than expected, can you re-review? |
ridz1208
approved these changes
Mar 8, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 3 methods of getting a reference to a database in LORIS, in order of preference:
The only reference to 3 left is in the implementation of option 2. This removes the Database::singleton by inlineing the reference into the factory and removes all remaining references to Database::singleton (mostly from documentation and a couple unit tests.)