Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dqt] Fix loading saved query #8436

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

zaliqarosli
Copy link
Contributor

Brief summary of changes

This bit of code was introduced in this PR and then reverted back in this PR.

I am reverting the code back to what it was when it was introduced as the 'keys' parameter in the query string wasn't changed back. I'm assuming reverting the code was a mistake when it got lumped in with the rest of the intended code changes

  • Have you updated related documentation?

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@zaliqarosli zaliqarosli added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Mar 9, 2023
@sruthymathew123
Copy link
Contributor

sruthymathew123 commented Mar 22, 2023

@zaliqarosli @driusan
Tested this with what suggested in #7041
Added many fields, Saved and see if everything is okay & Attempted to load query after browser refresh.

@sruthymathew123 sruthymathew123 added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 22, 2023
@driusan driusan merged commit c500dc1 into aces:24.1-release Mar 22, 2023
@ridz1208 ridz1208 added this to the 24.1.3 milestone Mar 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants