Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[NDB_BVL_Feedback] Fixing 500 error on instrument list page #8694

Merged
merged 1 commit into from
May 30, 2023
Merged

[NDB_BVL_Feedback] Fixing 500 error on instrument list page #8694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions php/libraries/NDB_BVL_Feedback.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ class NDB_BVL_Feedback
if (!empty($this->_feedbackObjectInfo['SessionID'])) {
$query .= " AND ft.SessionID = :SID";
$qparams['SID'] = $this->_feedbackObjectInfo['SessionID'];
$timepoint = Timepoint::singleton(
$timepoint = TimePoint::singleton(
new SessionID($qparams['SID'])
);
$hasReadPermission = (
Expand Down Expand Up @@ -580,7 +580,7 @@ class NDB_BVL_Feedback
} elseif (!empty($this->_feedbackObjectInfo['SessionID'])) {
$query .= " AND ft.SessionID = :SID AND ft.CommentID is null";
$qparams['SID'] = $this->_feedbackObjectInfo['SessionID'];
$timepoint = Timepoint::singleton(
$timepoint = TimePoint::singleton(
new SessionID($qparams['SID'])
);
$hasReadPermission = (
Expand Down