Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Candidate_parameters] Consent status - Add NA option #8732

Conversation

charlottesce
Copy link
Contributor

Brief summary of changes

Adding a N/A option for consent status. This is the expected behaviour:

  • Updating the consent status from Not Applicable to Yes/No is allowed
  • Updating the consent status from Yes/No to Not Applicable is NOT allowed
  • If Not Applicable is selected, no dates are required

Testing instructions (if applicable)

See test plan

Note

This is a CCNA override - https://github.com/aces/CCNA/pull/3822

@driusan
Copy link
Collaborator

driusan commented Jun 7, 2023

What is the use case for consent being not applicable?

@CamilleBeau
Copy link
Contributor

What is the use case for consent being not applicable?

@driusan I believe on CCNA this was requested when the consent was not asked or was not relevant for the participant in question. On CCNA we have consent on brain donation, but there is a shortened version of the protocol where candidates are not eligible for autopsies, so they wanted to enter N/A in this case.

@charliehenrib charliehenrib added the Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS label Aug 10, 2023
@laemtl laemtl added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Aug 10, 2023
@laemtl laemtl assigned ridz1208 and jeffersoncasimir and unassigned ridz1208 Nov 28, 2023
@laemtl laemtl removed the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Nov 28, 2023
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected

@jeffersoncasimir jeffersoncasimir added the Passed Manual Tests PR has undergone proper testing by at least one peer label Jan 22, 2024
@driusan driusan merged commit efe0439 into aces:main Jan 23, 2024
19 checks passed
kongtiaowang added a commit to kongtiaowang/Loris that referenced this pull request Jan 30, 2024
kongtiaowang pushed a commit to kongtiaowang/Loris that referenced this pull request Jan 30, 2024
Adding a N/A option for consent status. This is the expected behaviour:

- Updating the consent status from Not Applicable to Yes/No is allowed
- Updating the consent status from Yes/No to Not Applicable is NOT allowed
- If Not Applicable is selected, no dates are required

Removes CCNA override aces/CCNA#3822
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants