Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[data_release] Permission not added to unversioned files if version specified #8768

Conversation

charlottesce
Copy link
Contributor

Brief summary of changes

When adding version permissions for a user, permissions for unversioned files are no longer added

Testing instructions (if applicable)

  1. Go to data_release
  2. Make sure that there is at least one file uploaded without a version (version will show up as "Unversioned"), and at least one file uploaded under a specified version
  3. Add permissions for a user to give them permission to the specified version
  4. See that the user now only has permission to the specified version, and not "Unversioned" too

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Jun 14, 2023

@CamilleBeau you reported the issue this is reported to fix, can you review/test?

@CamilleBeau CamilleBeau added the Passed Manual Tests PR has undergone proper testing by at least one peer label Jun 19, 2023
@CamilleBeau
Copy link
Contributor

Works well & code looks good to me!

@driusan driusan merged commit baac2f4 into aces:25.0-release Jun 20, 2023
@ridz1208 ridz1208 added this to the 25.0.0 milestone Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
25.0.0 - Bugs Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants