Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[bvl_feedback] Edit comment section #8790

Merged
merged 7 commits into from
Aug 24, 2023
Merged

[bvl_feedback] Edit comment section #8790

merged 7 commits into from
Aug 24, 2023

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • Moved CCNA overrides to bvl_feedback module to LORIS Core
  • Switched Add Comment button from Pencil to a Comment (Original was confusing)
  • Set threads to be shown automatically for open threads as having them hidden made the UI confusing.
  • Added an Edit and Delete button for comments of which the author is the user viewing them
  • Flipped the order of comments around so that the newer comments show up below. Makes more sense when reading the comments
  • Made New Comment TextArea section show up below the thread, as that is where the new comment will appear
  • Changed panel width to work on mobile devices

Before:

Comment section

Behaviour:

  • Defaults to closed
  • Date is not shown
  • Comments are ordered in a confusing way
image

Mobile device

(Everything is cut off)
image

After:

Behaviour:

  • Defaults to open
  • Date is shown
  • Comments are in an easier to read order
  • Ability to delete and edit comments you wrote
image

Mobile device

image

@skarya22 skarya22 self-assigned this Jun 16, 2023
@skarya22 skarya22 added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 16, 2023
@skarya22 skarya22 removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jun 16, 2023
@skarya22 skarya22 removed their assignment Aug 10, 2023
@skarya22 skarya22 added the Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS label Aug 10, 2023
@shonibare shonibare self-assigned this Aug 10, 2023
shonibare
shonibare approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@shonibare shonibare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skarya22 @driusan
Update modules/bvl_feedback/jsx/react.behavioural_feedback_panel.js
6442cce 
Co-authored-by: Dave MacFarlane <driusan@gmail.com>
@driusan driusan merged commit b74e4ba into aces:25.0-release Aug 24, 2023
19 checks passed
@ridz1208 ridz1208 added this to the 25.0.1 milestone Nov 9, 2023
kongtiaowang pushed a commit to kongtiaowang/Loris that referenced this pull request Nov 29, 2023
@skarya22 @kongtiaowang
[bvl_feedback] Edit comment section (aces#8790)
8666064 
Fix display of bvl_feedback on mobile devices.

- Switched Add Comment button from Pencil to a Comment (Original was confusing)
- Set threads to be shown automatically for open threads as having them hidden made the UI confusing.
- Added an Edit and Delete button for comments of which the author is the user viewing them
- Flipped the order of comments around so that the newer comments show up below. Makes more sense when reading the comments
- Made New Comment TextArea section show up below the thread, as that is where the new comment will appear
- Changed panel width to work on mobile devices
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@driusan driusan driusan left review comments

@shonibare shonibare shonibare approved these changes

Assignees

@shonibare shonibare

Labels
Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Milestone
25.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@skarya22 @driusan @shonibare @ridz1208