-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[issue_tracker] Notifications #8850
Closed
skarya22
wants to merge
8
commits into
aces:main
from
skarya22:2023_07_24_Issue_Tracker_Notifications
Closed
[issue_tracker] Notifications #8850
skarya22
wants to merge
8
commits into
aces:main
from
skarya22:2023_07_24_Issue_Tracker_Notifications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarya22
added
the
Priority: Projects
PR or issue is a priority for at least one project and should be a higher priority for LORIS
label
Jul 27, 2023
skarya22
added
the
Needs Work
PR awaiting additional changes by the author or contains issues that the author needs to fix
label
Jul 31, 2023
skarya22
removed
the
Needs Work
PR awaiting additional changes by the author or contains issues that the author needs to fix
label
Jul 31, 2023
racostas
added
the
Passed Manual Tests
PR has undergone proper testing by at least one peer
label
Aug 10, 2023
racostas
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
looks good. |
racostas
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all fine.
Requested to make the changes onto 24.1-release instead. New PR made #8885 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Passed Manual Tests
PR has undergone proper testing by at least one peer
Priority: Projects
PR or issue is a priority for at least one project and should be a higher priority for LORIS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)
CCNA Overrides:
https://github.com/aces/CCNA/pull/3889
https://github.com/aces/CCNA/pull/4618