Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[issue_tracker] Notifications #8850

Closed

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • Fixed issue where the assignee dropdown did not show the current assignee
  • Emails users who were added as watching
  • When a comment is added, it adds it to the email to everyone watching

Testing instructions (if applicable)

  1. Open the issue tracker and add a user with your email address as the watcher to an issue
  2. Confirm that you received an email about the issue
  3. Try changing various fields and confirm an email is sent for each with some context.

Link(s) to related issue(s)

CCNA Overrides:
https://github.com/aces/CCNA/pull/3889
https://github.com/aces/CCNA/pull/4618

@skarya22 skarya22 added the Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS label Jul 27, 2023
@skarya22 skarya22 self-assigned this Jul 27, 2023
@skarya22 skarya22 added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jul 31, 2023
@skarya22 skarya22 removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Jul 31, 2023
@racostas racostas assigned racostas and unassigned racostas Aug 10, 2023
@racostas racostas self-requested a review August 10, 2023 14:18
@racostas racostas self-assigned this Aug 10, 2023
@skarya22 skarya22 removed their assignment Aug 10, 2023
@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label Aug 10, 2023
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas
Copy link
Contributor

looks good.

@racostas racostas self-requested a review August 10, 2023 16:07
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fine.

@skarya22 skarya22 changed the base branch from main to 24.1-release August 22, 2023 19:37
@skarya22 skarya22 changed the base branch from 24.1-release to main August 22, 2023 19:40
@skarya22 skarya22 changed the base branch from main to 24.1-release September 13, 2023 20:39
@skarya22 skarya22 changed the base branch from 24.1-release to main September 13, 2023 20:39
@skarya22
Copy link
Contributor Author

Requested to make the changes onto 24.1-release instead. New PR made #8885

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants