-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[LINST] fix survey and date issues #8858
Conversation
Code looks good. |
@@ -98,7 +98,9 @@ class NDB_BVL_Instrument_LINST extends \NDB_BVL_Instrument | |||
] | |||
); | |||
|
|||
if (strrpos($this->testName ?? '', '_proband') === false) { | |||
if (strrpos($this->testName ?? '', '_proband') === false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider moving this up
@CamilleBeau @charliehenrib @laemtl removed the change relating to age on direct instruments, I'll make a PR just for that for the remaining changes I think what needs to be tested is to have a LINST instruments with 3 different types of dates |
@zaliqarosli some changes derived from the QPN overrides that I believe apply to LORIS