Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[LINST/Dictionary] Add Numeric elements to dictionary #8869

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Aug 16, 2023

Currently the numeric element type is only being added to the instrument data dictionary if it's on the top page.

This fixes it so that the elements are always added to the dictionary regardless of the page.

Currently the numeric element type is only being added to the
instrument data dictionary if it's on the top page.

This fixes it so that the elements are always added to the dictionary
regardless of the page.
@driusan driusan merged commit b381816 into aces:24.1-release Aug 16, 2023
9 checks passed
driusan pushed a commit that referenced this pull request Aug 29, 2023
This adds a 'Description' field to the Conflict Resolver module (both Resolved and Unresolved tabs), which corresponds to the description of the 'Question' with the conflict. It uses /dictionary/module/instruments to get the description of the fields. Since some fields don't have descriptions (e.g. some _status variables), the empty string is used as default.

Changes have been made to the Instrument_LINST file such that numeric and date elements are added to the dictionary, even if they are not in the top page (inspired by the change in #8869).
@ridz1208 ridz1208 added this to the 24.1.5 milestone Nov 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants