[Core] Named form exports for Form.js #8880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Elements from Form.js, do not implicitly load them on window.
|
@kongtiaowang can you review and test this? |
driusan
added
Priority: High
kongtiaowang
added
the
Passed Manual Tests
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
exportkeyword for the classes defined in jsx/Form.js so that they can be imported with a more standard (ie)import {SelectElement, StaticElement} from 'jsx/Form';. It removes the globals onwindowand replaces all references in the code with an explicit import.This allows the element types to be imported from TypeScript strict mode without complaining about them not being defined.