[OIDC] Handle providers that don't provide a 'kid' parameter #8928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some OpenID Connect providers (ie. Globus) don't specify 'kid' in their JWKS response. The field is optional according to the spec, despite the fact that JWK::parseKeySet errors if it's not provided. As a workaround, this manually tries each key returned until one works. Partially resolves aces#8926.
driusan
added
the
Bug
jeffersoncasimir
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
The Globus key can successfully be generated with these changes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenID Connect providers (ie. Globus) don't specify 'kid' in their JWKS response. The field is optional according to the spec, despite the fact that JWK::parseKeySet errors if it's not provided.
As a workaround, this manually tries each key returned until one works.
Partially resolves #8926.