Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[SQL] Require test_names.Sub_group to not be null #8933

Merged
merged 2 commits into from
Nov 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SQL/0000-00-00-schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ CREATE TABLE `test_names` (
`ID` int(10) unsigned NOT NULL auto_increment,
`Test_name` varchar(255) default NULL,
`Full_name` varchar(255) default NULL,
`Sub_group` int(11) unsigned default NULL,
`Sub_group` int(11) unsigned NOT NULL,
`IsDirectEntry` boolean default NULL,
PRIMARY KEY (`ID`),
UNIQUE KEY `Test_name` (`Test_name`),
Expand Down
1 change: 1 addition & 0 deletions SQL/New_patches/2023-11-07-No-Null-Subgroup.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE test_names CHANGE Sub_group Sub_group int(11) unsigned not null;
1 change: 1 addition & 0 deletions modules/dashboard/test/DashboardTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ function setUp(): void
[
'ID' => '111',
'Test_name' => 'TestName11111111111',
'Sub_group' => 1,
]
);
$this->DB->insert(
Expand Down
Loading