[electrophysiology_browser] Fix gap between chunks #8998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersoncasimir
added
Bug
laemtl
approved these changes
Jan 16, 2024
driusan
pushed a commit
that referenced
this pull request
Jan 23, 2024
This resolves the data shift issue by adding the number of valid samples in the last chunk to the index.json, and using it for the calculations which previously assumed all chunks were filled. Closes #8992. Has a Loris-MRI counterpart: aces/Loris-MRI#1030 Loosely dependant on #8998 (file modifications in common and done at a later time).
|
@jeffersoncasimir This has conflicts and can't be merged. |
|
@jeffersoncasimir Now this branch doesn't have any changes according to the diff on GitHub. Can you confirm and close if that's the appropriate thing to do? |
This reverts commit ed5df9c.
jeffersoncasimir
added a commit
to jeffersoncasimir/Loris
that referenced
this pull request
Feb 29, 2024
This resolves the data shift issue by adding the number of valid samples in the last chunk to the index.json, and using it for the calculations which previously assumed all chunks were filled. Closes aces#8992. Has a Loris-MRI counterpart: aces/Loris-MRI#1030 Loosely dependant on aces#8998 (file modifications in common and done at a later time).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addressed #8717, since the full scope is two separate issues, by passing to a chunk the last point of the previous chunk. This connects the two chunks and no longer results in a visible gap.
Testing: Zoom in as much as possible between chunks and ensure that there is no visible gap.