Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Instrument List] Show Timepoint Project #9039

Merged

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Feb 1, 2024

Brief summary of changes

  • Changed the behaviour of showcasing the Candidate Registration Project on a visit's page. If the Timepoint Project differs from the Candidate Registration Project then it displays them separately, if they are the same then it shows the project under "Project"

Timepoint with a different project than the Candidate:

image

Timepoint with the same project as the Candidate:

image

Testing instructions (if applicable)

  1. Try adding a timepoint to a candidate with a different project
  2. See that it shows the correct Timepoint Project and Candidate Project
  3. Try different combinations including same timepoint and candidate project

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Feb 1, 2024

@kongtiaowang can you test this and then reassign to me?

@kongtiaowang kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label Feb 6, 2024
@kongtiaowang kongtiaowang assigned driusan and unassigned kongtiaowang Feb 6, 2024
@kongtiaowang
Copy link
Contributor

@driusan I have tested this PR, it works well.

@driusan driusan merged commit 144b1ed into aces:main Feb 6, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[instrument_list] Wrong timepoint project - shows candidate registration project instead
4 participants