Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[instrument_list] Fix deprecation warning (24.1) #9053

Merged
merged 2 commits into from
Feb 16, 2024
Merged

[instrument_list] Fix deprecation warning (24.1) #9053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d8a5f
fix strtolower deprecation warning
regisoc Feb 13, 2024
8fca9e0
rm dead code
regisoc Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions modules/instrument_list/php/instrument_list_controlpanel.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,11 +470,8 @@ class Instrument_List_ControlPanel extends \TimePoint
$qcStatus = $this->getBVLQCStatus();

foreach ($this->bvlQcTypes as $type) {
$isSelected =$type == $this->getBVLQCType();
$type =strtolower($type);
if ($type==null) {
$type ="none";
}
$isSelected = $type == $this->getBVLQCType();
$type = strtolower($type ?? 'none');
if ($isSelected) {
$this->tpl_data['bvl_qc_type_'.$type]['icon']
= 'far fa-check-square';
Expand Down Expand Up @@ -509,11 +506,8 @@ class Instrument_List_ControlPanel extends \TimePoint
$qcType = $this->getBVLQCType();

foreach ($this->bvlQcStatuses as $status) {
$isSelected =$status == $this->getBVLQCStatus();
$status =strtolower($status);
if ($status==null) {
$status ="none";
}
$isSelected = $status == $this->getBVLQCStatus();
$status = strtolower($status ?? 'none');
if ($isSelected) {
$this->tpl_data['bvl_qc_status_'.$status]['icon']
= 'far fa-check-square';
Expand Down
Loading