Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[help] fix the help widget extending over the height of a page #9105

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

shonibare
Copy link
Contributor

issue #9087

This PR fixes the help widget height extending over a page

@shonibare shonibare added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Feb 28, 2024
@ridz1208
Copy link
Collaborator

@shonibare can you provide screenshots of the before and after ?

@CamilleBeau CamilleBeau self-requested a review February 29, 2024 15:29
@CamilleBeau CamilleBeau self-assigned this Feb 29, 2024
@CamilleBeau CamilleBeau removed their request for review February 29, 2024 15:38
@CamilleBeau CamilleBeau removed their assignment Feb 29, 2024
@shonibare shonibare added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Feb 29, 2024
@shonibare
Copy link
Contributor Author

@ridz1208

Before

Screenshot 2024-02-29 at 1 51 30 PM

After
Screenshot 2024-02-29 at 1 52 39 PM

@shonibare shonibare removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Feb 29, 2024
@ridz1208
Copy link
Collaborator

ridz1208 commented Mar 1, 2024

@shonibare I still see it extending in width past the size of the page as described in the issue
it should not overflow horizontally either

@ridz1208 ridz1208 added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Mar 1, 2024
@shonibare
Copy link
Contributor Author

@shonibare I still see it extending in width past the size of the page as described in the issue it should not overflow horizontally either

Fixed @ridz1208
Screenshot 2024-03-01 at 10 36 54 AM

Screenshot 2024-03-01 at 10 37 35 AM

@skarya22 skarya22 self-assigned this Mar 7, 2024
@skarya22 skarya22 self-requested a review March 7, 2024 15:23
@skarya22 skarya22 removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Mar 7, 2024
@skarya22
Copy link
Contributor

skarya22 commented Mar 7, 2024

I can't seem to recreate the original issue with the horizontal space. Due to the horizontal fix, my help box seems to be 30px away from the right side of the screen now - is there a way to only add the 30px IF it is extending the page?

image

The vertical fix is working well though

@ridz1208
Copy link
Collaborator

ridz1208 commented Mar 7, 2024

@skarya22 change your first name last name to very short values (i.e. Rida test instead of Admin account) and you will get the horizontal issue

htdocs/main.css Outdated
@@ -684,11 +684,12 @@ tr.directentry {
border-top: none;
border-width: 1px;
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
position: absolute;
position: fixed;
right: 0;

I think this would be a better solution as it works irrelevant of how long the name is.

Copy link
Contributor Author

@shonibare shonibare Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it still works on my screen, updated the changes. I hope the help widget is positioned same place on your screen compared to your previous screenshot? @skarya22
Screenshot 2024-03-07 at 12 46 34 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes I could see it aligned with the right side of the screen no matter the name length! Thank you for updating with the changes requested

@skarya22 skarya22 self-requested a review March 7, 2024 18:42
Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@driusan driusan merged commit 1660e0e into aces:main Mar 11, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants