Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[configuration] Fix option deletion issue. #9121

Merged

Conversation

racostas
Copy link
Contributor

Brief summary of changes

The handler in configuration/jsx/configuration_helper.js was not properly taken the option to be deleted since the fields not always have necessary to be of SELECT type (they could be also text for example).
Now it should take the appropriate option to be deleted.

Testing instructions (if applicable)

  1. Please go to configuration module MainMenu->Admin->Configuration

  2. Go to one of the "Tabs" that allow multiselect (for example MINC to BIDS Converter Tool Options )

  3. Create some options and try to delete they after
    image

  4. Test Confirming and Canceling

  5. The field should be deleted under confirmation.

  6. Please test also with "other data type" (for example instruments in Study tab)

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Mar 12, 2024

This is failing eslint

   45:22  error    Multiple spaces found before '='                            no-multi-spaces

@driusan
Copy link
Collaborator

driusan commented Mar 12, 2024

@kongtiaowang can you test this?

@kongtiaowang kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 12, 2024
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit c0b1935 into aces:main Mar 13, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Config] Cannot delete an entry from a repeater
4 participants